Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webview] Replace Collection Project webview to use @vscode-elements package #1758

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Jan 10, 2025

This PR updates Ansible collection project webview to use @vscode-elements/elements package
insted of now deprecated @vscode/webview-ui-toolkit.

Added this new package, updated related code and styles.

For @vscode-elements package info refer: https://vscode-elements.github.io/getting-started/

Related: AAP-37621

@audgirka audgirka changed the title [Webview] Replace Ansible Collection Project webview to use @vscode-elements package [Webview] Replace Collection Project webview to use @vscode-elements package Jan 10, 2025
@audgirka audgirka marked this pull request as ready for review January 10, 2025 15:46
@audgirka audgirka requested review from a team as code owners January 10, 2025 15:46
Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the text for the ansible-creator log output is slightly less centered than it used to be. Comparing it to the original seems like the original was also off center, but it's a bit more noticeable now. If it could be centered in the logs text area completely, that would be ideal IMO.

Everything else looks great! It looks even better than before on some of the header spacings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants